| Anonymous | Login | Signup for a new account | 2013-05-25 01:53 CEST | ![]() |
| Main | My View | View Issues | Change Log | Roadmap | My Account |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |
| 0000289 | sigmah website | [All Projects] General | public | 2011-06-02 17:20 | 2012-07-17 16:40 | |
| Reporter | osarrat | |||||
| Assigned To | spM | |||||
| Priority | normal | Severity | minor | Reproducibility | always | |
| Status | closed | Resolution | fixed | |||
| Platform | OS | OS Version | ||||
| Product Version | ||||||
| Target Version | 2012w27 | Fixed in Version | 2012w27 | |||
| Summary | 0000289: Spaces missing between "By", forum post author name and "at" | |||||
| Description | Currently, a forum post made by fchaouki would be signed like "Byfchaoukiat". It should be corrected and presented like "By fchaouki at". And the author name should be made hyperlink to the author description page. (optionally) | |||||
| Tags | No tags attached. | |||||
| Attached Files | ||||||
Notes |
|
|
(0000864) spM (developer) 2012-03-24 22:13 edited on: 2012-03-25 01:00 |
This particular part is themed by the node-view-og_ghp_ron-default.tpl.php file. and the username part is printed in line number 62 : echo t('By').$name; and $name as the template file says, is the output of theme_user() (thats again another mistake, it is actually the output of theme_username() , which you can find in includes/theme.inc line number 1654. ) So, when we see the code of theme_username(), it returns a link to the profile of the user if the user has access permissions to view user profile, or simply the name of the user if the user doesnot have access permissions to view the profile. And, as it turns out, in sigmah-website, Anonymous users donot have permissions to access user profiles, so in that case, it returns a simple plaintext name in $name. So, now we put some conditionals, so now we replace line number 62 by // Code start // user_access is a drupal core function to check if the current user has required permissions. // Found at modules/user/user.module, line 508 if (user_access('access user profiles')) { echo t('By').$name; } else { echo t('By').' '.$name.' '; } // Code end This did the trick for me :) (You would need to empty the cache, and rebuild the theme registry to let drupal load the new template file :p ) |
|
(0000893) osarrat (administrator) 2012-04-03 15:06 |
Bug confirmed. Even though the given modification has been merged in my codebase, even after clearing the cache and setting to true the option "Rebuild theme registry on every page." for sigmah_theme, the bug remains (see attached screenshot). What else could be done? |
|
(0000894) spM (developer) 2012-04-03 18:23 edited on: 2012-04-03 18:25 |
Fishy enough, The above edit works perfectly fine on my local repository. (I have attached a screenshot of my copy, I wonder how could this be possible, the same code giving out different results) Still, I have tried not using the conditional, and always adding a space before the $name, I have committed the changes, refer https://github.com/spMohanty/sigmah-website/commit/933f1f46c4c4bcfb79bf7767ff26a2d2f7127766 [^] . |
|
(0000976) osarrat (administrator) 2012-06-25 15:52 |
Bug still confirmed. once again : Even though the given modification has been merged in my codebase, even after clearing the cache and setting to true the option "Rebuild theme registry on every page." for sigmah_theme, the bug remains (see attached screenshot missing-space-v2.png). Bug reproduced on top of page http://127.0.0.1:8000/sigmah-website/node/515 [^] Bug resolution postponed to 2012w27. |
|
(0000990) spM (developer) 2012-06-28 23:23 edited on: 2012-06-28 23:23 |
Its very difficult, when the particular issue doesnot appear on my local copy, but I suspect a particular template might also be the reason of different behaviour on different instances of the project. I have committed the changes , let me know, if this fixes the issue : https://github.com/spMohanty/sigmah-website/commit/9eba02e2aa789bf856909b41a5585bf081018404 [^] |
|
(0001018) osarrat (administrator) 2012-07-17 16:40 |
Issue closed because correct behavior checked on 2012w27. |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-06-02 17:20 | osarrat | New Issue | |
| 2012-03-24 22:13 | spM | Note Added: 0000864 | |
| 2012-03-24 22:26 | spM | Note Edited: 0000864 | View Revisions |
| 2012-03-24 22:26 | spM | Note Edited: 0000864 | View Revisions |
| 2012-03-25 01:00 | spM | Note Edited: 0000864 | View Revisions |
| 2012-04-03 15:06 | osarrat | Note Added: 0000893 | |
| 2012-04-03 15:06 | osarrat | Assigned To | => osarrat |
| 2012-04-03 15:06 | osarrat | Status | new => confirmed |
| 2012-04-03 15:08 | osarrat | File Added: missing_space.PNG | |
| 2012-04-03 18:23 | spM | Note Added: 0000894 | |
| 2012-04-03 18:23 | spM | File Added: Screenshot at 2012-04-03 21:31:43.png | |
| 2012-04-03 18:25 | spM | Note Edited: 0000894 | View Revisions |
| 2012-06-25 15:52 | osarrat | Note Added: 0000976 | |
| 2012-06-25 15:52 | osarrat | Assigned To | osarrat => spM |
| 2012-06-25 15:52 | osarrat | Status | confirmed => assigned |
| 2012-06-25 15:52 | osarrat | File Added: missing-space-v2.PNG | |
| 2012-06-25 15:53 | osarrat | Target Version | => 2012w27 |
| 2012-06-28 23:23 | spM | Note Added: 0000990 | |
| 2012-06-28 23:23 | spM | Note Edited: 0000990 | View Revisions |
| 2012-07-17 16:40 | osarrat | Note Added: 0001018 | |
| 2012-07-17 16:40 | osarrat | Status | assigned => closed |
| 2012-07-17 16:40 | osarrat | Resolution | open => fixed |
| 2012-07-17 16:40 | osarrat | Fixed in Version | => 2012w27 |
| Copyright © 2000 - 2010 MantisBT Group |